Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): fix render UI can't be inherit #1661

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(form): fix render UI can't be inherit #1661

merged 1 commit into from
Oct 19, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 19, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1661 (985dad6) into master (5edaa97) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Current head 985dad6 differs from pull request most recent head 98f8996. Consider uploading reports for the commit 98f8996 to get more accurate results

@@           Coverage Diff           @@
##           master    #1661   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         282      282           
  Lines        8756     8758    +2     
  Branches     1648     1649    +1     
=======================================
+ Hits         8365     8367    +2     
  Misses        323      323           
  Partials       68       68
Files Coverage Δ
packages/form/src/sf.component.ts 96.57% <ø> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit ee96aaa into master Oct 19, 2023
9 checks passed
@cipchk cipchk deleted the issues-2426 branch January 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sf的object组件属性会默认继承到子组件
2 participants
@cipchk @ng-alain-bot